fineprint-global/fabio

Feed requirement, process concordance

Closed this issue · 2 comments

nk027 commented

In 2b around line 340 we have the following concordance table:

data.frame(
  Proc.Code = c("p099", "p100", "p101", "p102", "p103", "p104", "p105", "p106", "p107", "p108", "p109"),
  Target.Proc.Code = c("p099", "p100", "p101", "p102", "p103", "p085", "p086", "p087", "p088", "p089", "p090")
)

So for example Poultry slaughtering has the target process Poultry Birds farming. Shouldn't that be the other way around? At least name-wise.
Also note that this is apparently not used at all.

nk027 commented

Never mind, it's renamed to "Proc.Code" later on.

martinbruckner commented

I have significantly revised the whole feed part. It should be fine now.

  • ❤️1