Issues in recent commit
Closed this issue · 0 comments
nk027 commented
I spotted some issues in the most recent commit:
build_cbs#308
now includes item code2001
(grazing), which is not an actual item, but rather estimated later on. Adding it here is misleading.tidy_functions#area_kick()
is now broken - thegroup
argument no longer kicks groups, but also some countries in an intransparent way. Countries should be kicked separately by providing theirarea_code
and optionally name in the style of China.tidy_fao#Livestocks
now breaks the script's logic -live_trade
should either be tidied separately, or fully in joint with the rest oflive
. Item codes should be remapped via concordance tables and not within scripts (live_trad[
Item Code%in% c(1057,1068,1079,1083) ,
Item Code:= 2029]
)