fineprint-global/fabio

Misplaced price assumption

Closed this issue · 1 comments

nk027 commented

Here https://github.com/nk027/fabio/blob/5db43338a24bd86db7bf8b3b8212a2cc9b63cda0/R/8_mrio.R#L45 missing prices are implicitly equated to 1.

  • I don't think that's a reasonable assumption
  • This should be done earlier on, when building the supply table (same for the value column)

That's intended and unproblematic, as the values are only needed to split by-products.