finos/git-proxy

Installation and usage instructions do not load the user interface ⚡

Closed this issue · 6 comments

Describe the bug
A clear and concise description of what the bug is.

When following the installation and usage instructions, the proxy and service start as expected:

Proxy Listening on 8000
Service Listening on 8080

However, when navigating to the UI (http://localhost:8080), the following error is presented in the browser:

Error: ENOENT: no such file or directory, stat '/Users/jamie/.nvm/versions/node/v20.3.1/lib/node_modules/@finos/git-proxy/build/index.html'

To Reproduce
Steps to reproduce the behavior:

  1. npm install -g @finos/git-proxy@1.2.1
  2. Run git-proxy from a terminal or command line
  3. Visit localhost:8080
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

When visiting localhost:8080 we should expect to see the main dashboard page appearing:

Screenshot 2024-05-21 at 15 31 55

Desktop (please complete the following information):

  • OS: Mac
  • Browser: Chrome
  • Version: @finos/git-proxy@1.2.1

@tt-gideonaryeetey, @divinetettey - are you interested in picking this one up? 👍

@JamieSlome Yes! I'll take care of it. Please assign it to me.

@tt-gideonaryeetey - since merging #575 and release in #577, it appears that the issue remains? Can you verify?

@JamieSlome The issue remains. It appears the build directory was ignored by the npm registry. We need to add an empty .npmignore file to override .gitignore. That way the build directory would not be ignored.
I will do that and create a PR. Thanks!
Reference here

@tt-gideonaryeetey - it looks like we've hit the moon 🚀 🌔 Great job!

Can you confirm on your side? I'll close this issue as completed once I hear back.

@tt-gideonaryeetey - it looks like we've hit the moon 🚀 🌔 Great job!

Can you confirm on your side? I'll close this issue as completed once I hear back.

Nice! It's working for me too. 🎉