finos/greenkey-asrtoolkit

Potential typo in align_json.py

kaleko opened this issue · 1 comments

kaleko commented

Describe the bug
Line 58 of align_json.py: https://github.com/finos/greenkey-asrtoolkit/blob/master/asrtoolkit/align_json.py

Should this be "align_json(", not "align_gk_json("? I don't see align_gk_json anywhere else in the repo.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Execute '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
  • Python version
  • Using docker or pip package?

Additional context
Add any other context about the problem here.

mgoldey commented

Thanks a bunch for catching this. Potential fix up and will re-evaluate testing procedure.