firebase/codelab-friendlychat-ios

Firebase iOS Codelab Swift - Step 5 Error

dominiclancaster opened this issue · 2 comments

dominiclancaster commented

For https://codelabs.developers.google.com/codelabs/firebase-ios-swift/#4, under step 5 SignInViewController.swfit section, the following code

GIDSignIn.sharedInstance().uiDelegate = self GIDSignIn.sharedInstance().signInSilently()

should be

GIDSignIn.sharedInstance().presentingViewController = self GIDSignIn.sharedInstance().restorePreviousSignIn()

Reference: https://developers.google.com/identity/sign-in/ios/quick-migration-guide

morganchen12 commented

@kroikie can you take a look at this? I made some changes internally that are still pending, but we'll want both this and the objc codelab fully updated before May.

amrabed commented

For the same step, shouldn't the Podfile also contain the following line?

pod 'GoogleSignIn'

Reference: https://firebase.google.com/docs/auth/ios/google-signin#before_you_begin