Multiple build issues
claresudbery opened this issue · 2 comments
Hi
I am trying to follow this tutorial but there have been multiple issues:
- The Firebase/AdMob pod results in two conflicting installations for both Firebase and GoogleUtilities
- (you get Firebase 3.6.0 as well as latest Firebase, and you get GoogleUtilities 1.3.2 and 7.13.0)
- This results in license errors during pod installation ("eg Unable to read the license file
LICENSE
for the specFirebase (9.6.0)
") and build errors when building (eg says it can't find the GoogleUtilities import) - Some Googling suggested I swap the Firebase/AdMob pod for the Google-Mobile-Ads-SDK pod, but this resulted in various build errors because this code is using GIDSignInDelegate, which is now deprecated. I tried following the migration guide (https://developers.google.com/identity/sign-in/ios/quick-migration-guide) but I didn't understand this code well enough to be able to do this. I did manage to finally get the code to build by simply commenting out some code and changing some other bits, but once the project was finally running, I got an error "The Google Mobile Ads SDK was initialized without an application ID. Google AdMob publishers, follow instructions at https://googlemobileadssdk.page.link/admob-ios-update-plist to set a valid application ID. Google Ad Manager publishers, follow instructions at https://googlemobileadssdk.page.link/ad-manager-ios-update-plist." 0x000000010e307c40" and at this point I gave up as I really only want to follow a simple Firebase tutorial rather than address all these issues, and I know nothing about Google Ad Manager or AdMob.
Hi
I managed to get an application ID and get the code running, but now the tutorial says I need to add the line "GIDSignIn.sharedInstance().delegate = self" to the didFinishLaunchingWithOptions application function in AppDelegate.swift. This is the line of code I had to comment out before, because GIDSignIn has changed and the shared instance no longer has a delegate property. I checked the migration guide for google Signin, but it didn't help me work out how to fix this.
migration guide: https://developers.google.com/identity/sign-in/ios/quick-migration-guide
I have created a PR of the changes I needed to make to get the app to build and run: #242
See notes in the PR though - I believe there is still work needed to get the GIDSignIn stuff working.
Also anyone using this code will need to add their own app id into info.plist (currently line 63).