firebase/firebase-ios-sdk

GitHub/CocoaPods Releases Missing (9.4.0 & 9.4.1)

Salakar opened this issue · 7 comments

[REQUIRED] Step 1: Describe your environment

N/A

[REQUIRED] Step 2: Describe the problem

Hey all, we have build failures over at https://github.com/invertase/firestore-ios-sdk-frameworks with the 9.4.x releases, not sure if you're aware but:

  • 9.4.0 is missing a GitHub release but exists on CocoaPods
  • 9.4.1 has a GitHub release but does not exist on CocoaPods

So we're unable to use either version since either GitHub release or a CocoaPods release is missing on each.

Steps to reproduce:

N/A

Relevant Code:

N/A

. Sorry about the confusion.

9.4.1 was a Swift Package Manager only release since we created the 9.4.0 tag wrong. The zip distribution is the same for either. CocoaPods-9.4.0 is equivalent to 9.4.1 https://github.com/firebase/firebase-ios-sdk/tags

The problem is without 9.4.0 (which exists on cocoapods, so it's the version we will try to pull / re-package) having a release entry here https://github.com/firebase/firebase-ios-sdk/releases - we can't find the correlating zip to unpack / repack

Would it help to make a 9.4.0 release on GitHub that exactly matches the 9.4.1 release?

I'm reading through this right now to see what would actually resolve it (also figure out why it isn't resolving now)

https://github.com/invertase/firestore-ios-sdk-frameworks/blob/dc59623e1ac126bbc1e1ed10f78126f8d87c8b6f/.github/workflows/scripts/process-latest-version.sh#L118-L151

output:


/Users/runner/.cocoapods/repos/trunk/Specs/0/3/5/Firebase/9.4.0/Firebase.podspec.json
The latest Firebase pod version is 9.4.0, checking if a frameworks release tag exists.
Found FirebaseFirestore subspec with version '9.4.0'
A frameworks tag for Firebase pod version 9.4.0 does not yet exist, creating it...
Warning: could not find a release with the tag 9.4.0 on the firebase/firebase-ios-sdk repository.
Warning: backup check for tag CocoaPods-9.4.0 on the firebase/firebase-ios-sdk repository also failed.
Error: backup check for tag v9.4.0 on the firebase/firebase-ios-sdk repository also failed.
Error: Process completed with exit code 1.

We've added a few secondary checks in there as the tags here have changed a bit over time, it's possible we can just add another clause

I think an actual release on the 9.4.0 tag would satisfy the logic constraints in the script and it would all hook up and complete, yes

That did the trick! Our script is off to the races now:

Found archive asset, downloading from url https://github.com/firebase/firebase-ios-sdk/releases/download/9.4.0/Firebase.zip ...