Project is some update needs. (gradle.properties, AndroidMnifest.xml, google-services.json)
masteage opened this issue · 2 comments
masteage commented
Please fill in the following fields:
- macOS Catalina : 10.15.6
- Android Studio : v4.0.1
- Firebase C++ SDK version : v6.15.1
- Firebase plugins in use : admob
- Platform you are targeting Android (Simulator)
Please describe the issue here:
-
gradle.properties
- add file "gradle.properties"
- add Adndroid X setging
- add firebase c++ sdk setting
- 742e95d
-
AndroidMnifest.xml
- add sample admob app id
- 6b4f583
-
google-services.json
- add mock google-services.json
- e225bcb
- from : https://github.com/firebase/quickstart-android/blob/master/mock-google-services.json
Please answer the following, if applicable:
-
Have you been able to reproduce this issue with just the Firebase C++ quickstarts (this GitHub project)?
- -> YES
-
What's the issue repro rate? (eg 100%, 1/5 etc)
- -> 100%
chkuang-g commented
Hi @masteage
Thank you for the suggestions.
I think the AndroidX/Jetifier change in gradle.properties make sense. However, all of the others are documented in readme.
I think you still need to follow instructions from readme for the sample Admob App Id and mock google-services.json anyway. Is there a particular reason you think those change are necessary?
Shawn
chkuang-g commented
BTW, currently we do not accept pull request in this repo.