firebase/snippets-node

Syntax highlighting not working correctly

IvanBila opened this issue ยท 6 comments

Summary

As a side effect of #46, the current documentation syntax highlighting is not working as expected some parts get syntax highlighting but all that include let are not, I've attached the screenshot below for reference.

Preview

Screenshot from 2019-06-09 14-57-19

Thanks @IvanBila it looks like our syntax highlighter is not ready for modern JavaScript, I will follow up with the documentation team and see if we can update it. Hopefully it's not a hard change to make.

Hopefully it's not a hard change to make.

Well turns out it's an extremely hard change to make because of silly internal Google things. But I am working on it.

@samtstern Is it possible to maybe revert the commit that uses let until this issue is fixed? let me know what is your opinion.

@IvanBila I think I'd prefer the nicer code over the nicer colors

@samtstern I also agree on that, talking about nice code, (OFF TOPIC)I wanted to add async/await as an extra part of the docs(maybe at the bottom), where I just show how to do the same thing using async await. What is your opinion on this?

@IvanBila looks like all instances of let have been replaced with const and async/await has been added in #121
Closing this now