firebolt-db/dbt-firebolt

Use only setup.cfg in lieu of setup.py

dataders opened this issue · 2 comments

dataders commented

#20 adds a setup.cfg to our project even though we already have a setup.py. This will only cause problems for us by not having a single source of truth for package configuration. This should be addressed at somepoint

Might be wrong here, but I'm fairly certain we don't need this file. We're currently using setup.py instead of a .cfg. relevant SO question?

Originally posted by @swanderz in #20 (comment)

ima-hima commented

#20 adds a setup.cfg to our project even though we already have a setup.py. This will only cause problems for us by not having a single source of truth for package configuration. This should be addressed at somepoint

Might be wrong here, but I'm fairly certain we don't need this file. We're currently using setup.py instead of a .cfg. relevant SO question?

Originally posted by @swanderz in #20 (comment)

Fully agree. I'll add a Jira todo and take care of this ASAP.

ericf-firebolt commented

Done in #33