firecracker-microvm/firecracker

Misleading comment about where the queue starts and its size

Closed this issue · 1 comments

Hello,

IIUC, the virtqueue starts at QUEUE_BASE_ADDRESS, which is not 0. So the comment shall state that. The comment is at

/// The address of the first byte after the queue. Since our queue starts at guest physical

Also QUEUE_END is not the size if the starting address is not zero so the definition at

const GUEST_MEMORY_SIZE: usize = QUEUE_END as usize + 30;
may be wrong.

Thanks.

Heya! Yeah, those are indeed wrong... let's me post a PR to fix that, thanks!