firedancer-io/radiance

Can compactindex be built for non-unix platforms?

gagliardetto opened this issue · 3 comments

Right now, compactindex only compiles to unix-like OSs:

//go:build unix

Are there any particular issues when compiling to windows?

@gagliardetto Thanks for pointing this out. compactindex is fully portable to any target that supports Go 1.19, not just Unix. That build constraint was added because of the use of fallocate. But the code now contains a generic fallocate for non-Linux targets, so this line can be removed. Would you mind PRing a removal of this build constraint? Many thanks

opened #121

Thanks!