Merge with "official" Magento-ECG Sniffs?

Question

Merge with "official" Magento-ECG Sniffs?

Opened this issue 10 years ago · 2 comments

Is there a comparison with https://github.com/magento-ecg/coding-standard ?

Answer 1 · 2014-07-02T10:07:02.000Z

Vinai,
thanks for the suggestion.

The ECG standard checks way more stuff. We need to distinguish all the differences and maybe incorporate some of them in the FireGento Coding Standard. We have added some additional checks e.g. for a correct license, author, etc..

Answer 2 · 2014-07-02T10:16:57.000Z

Nothings wrong with using two standards, but it would be nice if there where no duplicates.
Maybe the firegento standard should build on top of the ECG one? What do you think?