Possible typo in 4.1.14 patch files
marioroy opened this issue ยท 3 comments
marioroy commented
Hi Masahito,
I'm comparing 4.1.13 and 4.1.14 and noticed a typo on line 553 in 0001-linux6.6.y-cachyos-bore4.1.14.patch
. See also 0001-linux6.7.y-bore4.1.14.patch
and 0001-linux6.8.y-bore4.1.14.patch
, line 549.
.proc_handler = proc_douintvec,
The line is missing &
.
.proc_handler = &proc_douintvec,
marioroy commented
Please disregard this issue. Reading the .proc_handler =
lines in kernel/sched/fair.c is confusing with/without &
.
marioroy commented
Thank you, for 4.1.14r2. This is no longer confusing and now matching the other areas of the kernel. E.g. grep -r proc_dobool .
from the base dir.
$ grep proc_handler 0001-linux6.6.y-bore4.1.14r2.patch
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dou8vec_minmax,
+ .proc_handler = proc_dou8vec_minmax,
+ .proc_handler = proc_douintvec_minmax,
+ .proc_handler = proc_douintvec,
$ grep proc_handler 0001-linux6.7.y-bore4.1.14r2.patch
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dobool,
+ .proc_handler = proc_dou8vec_minmax,
+ .proc_handler = proc_dou8vec_minmax,
+ .proc_handler = proc_douintvec_minmax,
+ .proc_handler = proc_douintvec,
Is the update needed in the bore 6.1.y patch? I'm not seeing other areas of the 6.1 kernel using &
.
$ grep proc_handler 0001-linux6.1.y-bore4.1.13r2.patch
+ .proc_handler = &proc_dobool,
+ .proc_handler = proc_douintvec,
+ .proc_handler = &proc_dou8vec_minmax,
+ .proc_handler = &proc_dou8vec_minmax,
+ .proc_handler = &proc_douintvec_minmax,
+ .proc_handler = &proc_dobool,
+ .proc_handler = &proc_dobool,
+ .proc_handler = &proc_dobool,
For example, I did a search in the XanMod 6.1 kernel.
mm/hugetlb_vmemmap.c: .proc_handler = proc_dobool,
net/mptcp/ctrl.c: .proc_handler = proc_douintvec_minmax,
net/mptcp/ctrl.c: .proc_handler = proc_dou8vec_minmax
firelzrd commented
Thank you so much for the reporting! ;)