firepicaso/ror-recipe-app

Review Kanban Board Setup

firepicaso opened this issue ยท 5 comments

Review Kanban Board Setup

Link to Github Project:

https://github.com/users/firepicaso/projects/5

We are a group of three members

Hi @firepicaso, @mumbereh and @albertkantwi,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

  • I get 404 error when I visit your page. Kindly rectify that.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready ๐Ÿ™

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Hi Team,

Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Fair distribution of tasks โœ”๏ธ
  • Good use of Kanban Board โœ”๏ธ

Required Changes โ™ป๏ธ

Check the comments under the review.

  • While you've done a great job, you probably forgot to add a description to the cards individually, I will encourage you to do this so as to be clear to the person working on the project while at it.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thanks for the review @Olamarx.
We have added descriptions to all the tasks.

Hi <STUDENT_MENTION>,

GIF

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! ๐ŸŽ‰

Highlights

โœ… You used Gitflow correctly ๐Ÿ‘
โœ… No linter error ๐Ÿ‘
โœ… Good commit messages ๐Ÿ‘
โœ… Good descriptive PR ๐Ÿ‘
โœ… Well done ๐Ÿ‘ you did all changes given by the previous reviewer ๐Ÿ‘

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.