Review Kanban Board
Opened this issue · 3 comments
Link to Github Project:
https://github.com/users/firepicaso/projects/5
We are a group of two members
STATUS: CHANGES REQUIRED ♻️ ♻️
Hi @firepicaso and @mumbereh,
Good job so far!
✔️ Kanban columns are complete
✔️ Tasks are assigned
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
-
Most of your task titles and descriptions are not aligned to match the descriptions of the tasks in their entirety. Now, you are free to add additional tasks you wish to work on but the basic tasks on the requirements should be present and match the ones on the project requirements at minimum.
List of task titles Example descriptive For example, the second image above does not give any indication that you are trying to accomplish the following task, but it should.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thank you for the feedback @TedLivist
We have updated the descriptions of the tasks to reflect the requirements of the project.
Your project is complete 👍 💯 There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights 👏🏻
✔️ Correctly Set up RoR group project: set up your Kanban board
✔️ Correctly organization and description about the number of people in group.
✔️ Good job for Implemented Suggested changes.
Optional suggestions
_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.