firstcontributions/firstcontributions.github.io

Improve general website design (small fixes)

Lorenzobattistela opened this issue · 3 comments

Lorenzobattistela commented

🐞 Problem
The website is functional and does what it is meant for. However, the design could improve a lot with some simple fixes.
Some of those fixes are:

  • Changing default font of cards text
  • Improve Get Started button design (size, margin)
  • Adjust spaces between title (Make your first..), navbar and button (spaces are not equal)
  • Center navbar (this can be discussed)
  • Delete the frase "the framework or language that the project is build upon" that is present in some of the cards.
  • Adjust padding on projects topics on each card.
  • Adding dark mode

🎯 Goal
For me, this change is important because affects the first impression about the project and the website. The design is certainly really important so that the website looks as good as possible for the user. It helps attracting him to like and use the service, and even recommend it to others.

At first sight, it could look like fonts and paddings are not that important but it does a huge difference when you enter a website and it is well spaced, with different fonts and well designed.

💡 Possible solutions

Changing mainly CSS and using some javascript to add dark mode (saving on localstorage the choice).

📋 Steps to solve the problem

  • Changing default font of cards text
  • Improve Get Started button design (size, margin)
  • Adjust spaces between title (Make your first..), navbar and button (spaces are not equal)
  • Center navbar (this can be discussed)
  • Adjust padding on projects topics on each card.
  • Comment below about what you've started working on.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for reviews in comments section of pull request.
  • Celebrate your contribution to this project. 🎉
Roshanjossey commented

Hi @Lorenzobattistela,

Thank you for your interest in this project. I like the suggestions you made.

We're in the process of building a completely new webapp from scratch that would succeed this one.

I'm not trying to discourage you. I'm sure that the things you learn by working on this issue will help you but I wanted to give you the big picture from from maintainers' perspective when you're putting in the effort.

Lorenzobattistela commented

Hi @Lorenzobattistela,

Thank you for your interest in this project. I like the suggestions you made.

We're in the process of building a completely new webapp from scratch that would succeed this one.

I'm not trying to discourage you. I'm sure that the things you learn by working on this issue will help you but I wanted to give you the big picture from from maintainers' perspective when you're putting in the effort.

No problem! I already did some code changes and will send the PR anyway, I am just starting to contribute with open source so it is a good learning for me. Thanks

anasaijaz commented

Hi @Roshanjossey is the new webapp also open source, can you please share the link!