Add PWA support for the application with offline support
Aniket762 opened this issue · 10 comments
A progressive web application is a type of application software delivered through the web, built using common web technologies including HTML, CSS, and JavaScript. It is intended to work on any platform that uses a standards-compliant browser, including both desktop and mobile devices. Progressive Web Apps (PWAs) allow developers to deliver an app-like experience to the user.
I would like to work on the issue, in case you don't want PWA support feel free to close the issue! Looking forward to working contribute to one of the best Org out there ⚡️
Hi @Aniket762
Could you have any thoughts on what would be efforts to this ?
Also for the current website we use hugo framework and docsy base theme.
Hey, @sanketsudake thanks for replying means a lot. From the documentation I got it's built on Hugo, as I have never implemented PWA with Hugo, I googled it and it was pretty smooth. I would like to give it a shot. I hope that's what you asked for!
Can you please assign this to me?
Thanks for your interest. 👍 Assigned it.
Hey, @sanketsudake I have created pull request #70 and have also attached the screenshots. Please do check it and let me know if some changes are to be made. Extremely sorry for the delay in creating the Pull Request, I was admitted to the hospital and it took me time to recover and start working again. Hope you understand!
I want to work on other issues and have seen some bugs while creating the PWA would like to solve them once the Pull request gets merged. So let me know about the changes will be more than happy to do it 🙈
Hey, @Aniket762 Thanks for PR #70 . I have posted a few of my initial thoughts. I don't have much expertise in PWA, so I might have missed your thought process.
Could you also check the preview generated by Netlify in the PR?
https://deploy-preview-70--fission-website.netlify.app
Regarding further fixes, you have mentioned, happy to accept them.
@Aniket762 PR is merged. Please validate fission.io in some time and let me know if we can close this issue.
If you have plans to make further changes, we can track them in another issue.
@Aniket762 PR is merged. Please validate fission.io in some time and let me know if we can close this issue.
If you have plans to make further changes, we can track them in another issue.
Sure!
Hey @Aniket762, Did you get a chance to verify PWA on https://fission.io? Do we need any further changes?
Hey @Aniket762, Did you get a chance to verify PWA on https://fission.io? Do we need any further changes?
Yes, there is an error I will be sending another PR this weekend. I will host the application on vercel from my end then make sure it works well in prod then do finally send the PR
Hey, @sanketsudake I have sent the PR do check it out. I have also deployed my version on Netlify and it is working
Here is the link: https://naughty-lumiere-b1b148.netlify.app/
Even on the Netlify preview of the master branch it is showing PWA.
Link to preview: https://deploy-preview-73--fission-website.netlify.app/
Hopefully, it works on the master prod