Colorful tag patch

Question

Colorful tag patch

siduck opened this issue 3 years ago · 45 comments

Hi @fitrh , I have seen your post on imgur

here : https://imgur.com/t/linux_desktop/W7lQkXB

Can you share the colorful tag patch? Im currently using rainbow tags but feels ugly

Answer 1 · 2021-07-24T07:27:46.000Z

The main implementation is here d139433 and later update is here 4e8cc1d, sorry for the dirty diff, i have a plan to release all my personal patch but i think i have to clear the diff first.

BTW, what you look at that screenshot is not only the colorful tag, there are colorful title, bar line indicator, and vacant tag patch

Answer 2 · 2021-07-24T07:49:04.000Z

The main implementation is here d139433 and later update is here 4e8cc1d, sorry for the dirty diff, i have a plan to release all my personal patch but i think i have to clear the diff first.

BTW, what you look at that screenshot is not only the colorful tag, there are colorful title, bar line indicator, and vacant tag patch

Yeah I've seen your commits , however I want only colorful tags tho :)

Answer 3 · 2021-07-24T08:07:10.000Z

Just use those 2 commits

Answer 4 · 2021-07-24T08:22:06.000Z

Just use those 2 commits
I did but i dont have alttag patch added :c

where do I add this?

Answer 5 · 2021-07-24T08:31:45.000Z

Inside the drawbar function, before you draw the tag, tag drawing look like this (i'm using alttag patch)

drw_text(drw, x, y,
        w + y, h, wdelta + lrpad / 2,
        (m->alttag ? tagsalt[i] : tags[i]),
        urg & 1 << i);

Answer 6 · 2021-07-24T08:34:31.000Z

Inside the drawbar function, before you draw the tag, tag drawing look like this (i'm using alttag patch)
drw_text(drw, x, y,
        w + y, h, wdelta + lrpad / 2,
        (m->alttag ? tagsalt[i] : tags[i]),
        urg & 1 << i);

idk C ,you mean this function?

https://github.com/siduck76/chadwm/blob/main/chadwm/dwm.c#L1272

Answer 7 · 2021-07-24T08:35:41.000Z

Is you trying to apply the patch for this build ? if so, addit before this line

Answer 8 · 2021-07-24T08:36:36.000Z

Inside the drawbar function, before you draw the tag, tag drawing look like this (i'm using alttag patch)
drw_text(drw, x, y,
        w + y, h, wdelta + lrpad / 2,
        (m->alttag ? tagsalt[i] : tags[i]),
        urg & 1 << i);
idk C ,you mean this function?

https://github.com/siduck76/chadwm/blob/main/chadwm/dwm.c#L1272

Yes, replace that line

Answer 9 · 2021-07-24T15:12:32.000Z

@fitrh i tried adding it but i get colored icons only if the tag is active :/ or it just uses SchemeTag for the rest of that tags

Answer 10 · 2021-07-24T15:17:14.000Z

I added the colorful patch only : siduck/chadwm@d1223ea

Answer 11 · 2021-07-24T15:36:51.000Z

Ah, that's how it is work, only the selected tag is colored, what you see in my screenshot is when using all tag view mode (Mod-0 by default) a.k.a all the tags get selected.

Ff you want the tags colored all the time, remove the conditional checking and make it something like this

drw_setscheme(drw, tagschemes[i]);

Answer 12 · 2021-07-24T16:03:03.000Z

```c
drw_setscheme(drw, tagschemes[i]);

wouldnt it be better to color them only if they're occupied? :D

Answer 13 · 2021-07-24T16:10:52.000Z

Ah, that's how it is work, only the selected tag is colored, what you see in my screenshot is when using all tag view mode (Mod-0 by default) a.k.a all the tags get selected.

Ff you want the tags colored all the time, remove the conditional checking and make it something like this
drw_setscheme(drw, tagschemes[i]);

I did that and my whole dwm crashed :( ,keybinds werent working too

Answer 14 · 2021-07-24T16:53:56.000Z

Sorry, you should use it as an index to scheme like this

drw_setscheme(drw, scheme[tagschemes[i]]);

and if you use colorfultag configuration, dont forget to add it

drw_setscheme(drw, scheme[m->colorfultag ? tagschemes[i] : SchemeSel]);

Answer 15 · 2021-07-24T16:58:55.000Z

wouldnt it be better to color them only if they're occupied? :D

Yes, you could do that, just change the condition, use m->sel instead, like this

drw_setscheme(drw, scheme[m->sel ? (m->colorfultag ? tagschemes[i] : SchemeSel) : SchemeTag]);

Answer 16 · 2021-07-24T17:21:35.000Z

wouldnt it be better to color them only if they're occupied? :D

Yes, you could do that, just change the condition, use m->sel instead, like this
drw_setscheme(drw, scheme[m->sel ? (m->colorfultag ? tagschemes[i] : SchemeSel) : SchemeTag]);

I added only this and it removes the colors if current workspace has no windows :c

simplescreenrecorder-2021-07-24_22.34.50.mp4

Answer 17 · 2021-07-24T17:29:36.000Z

I want tags ( having 0 windows ) to have normal color and occupied have their (tagsel colors) too , is this possible?

Answer 18 · 2021-07-24T17:29:37.000Z

Can you tell me what behavior you want ? like what happen if the tag is selected/unselected or what happen if there are a client or not, actually it is very customizable

Answer 19 · 2021-07-24T17:30:40.000Z

wouldnt it be better to color them only if they're occupied? :D

'occupied' means there are a client ?

Answer 20 · 2021-07-24T17:30:50.000Z

Can you tell me what behavior you want ? like what happen if the tag is selected/unselected or what happen if there are a client or not, actually it is very customizable

( tags = workspace)
suppose 1,2 tags are occupied

I go to 3rd tag and its empty by default so all tags reset to normal colors which I dont want!

Answer 21 · 2021-07-24T17:30:58.000Z

```c
drw_setscheme(drw, tagschemes[i]);
wouldnt it be better to color them only if they're occupied? :D
'occupied' means there are a client ?

yes

Answer 22 · 2021-07-24T17:50:44.000Z

Maybe occ & 1 << i is what you mean, so replace the m->sel

drw_setscheme(drw, scheme[occ & 1 << i ? (m->colorfultag ? tagschemes[i] : SchemeSel) : SchemeTag]);

Answer 23 · 2021-07-24T18:03:53.000Z

thanks for the help @fitrh! seems like you're writing your own nvim config in lua too , you could check and use my config (nvchad) https://github.com/siduck76/NvChad , I cant thank you enough!

Answer 24 · 2021-07-24T18:08:06.000Z

Thank you, nice config btw, but i always prefer to write config by my self because it always give the best of understanding

Answer 25 · 2021-10-03T20:16:54.000Z

Hi, I path my dwm with your code, and it doesnt crash jeje, but. How can I put the colors on every tag name, I mean, have the colors even if the tags are empty. Hope you can help me with thath. Regards from mexico.

Answer 26 · 2021-10-04T01:34:00.000Z

Hi @engjpacheco, inside the loop for drawing tags, just put something like this drw_setscheme(drw, tagschemes[i])

Answer 27 · 2021-10-04T01:37:53.000Z

In my recent build, remove these lines and replace this line with above code

Answer 28 · 2021-10-04T02:55:58.000Z

ok, i´ll try, remove the if statent and replace this drw_setscheme(drw, scheme[tagscheme]); with this: drw_setscheme(drw, tagschemes[i])

Thank u so much, you definetly need to do the patch and post it to suckless page, ASAP, jeje.

Thank you again, regards from Mexico.

Answer 29 · 2021-10-04T04:36:34.000Z

ok, i´ll try, remove the if statent and replace this drw_setscheme(drw, scheme[tagscheme]); with this: drw_setscheme(drw, tagschemes[i])

Thank u so much, you definetly need to do the patch and post it to suckless page, ASAP, jeje.

Thank you again, regards from Mexico.

agreed! @fitrh you gotta submit this awesome patch to suckless page :D

Answer 30 · 2021-10-14T03:10:00.000Z

@fitrh I made it, I kinda make a hybrid mode with rainbow tags and some of your knowledge. Here are the result of the tags :)

Answer 31 · 2021-10-14T03:21:30.000Z

@engjpacheco cool, I suggest you to combined it with vacant tags, or even bar border, gap, and indictor and make it toggleable

simplescreenrecorder-2021-10-14_11.11.24.mp4

Answer 32 · 2021-10-14T03:25:26.000Z

Yeah I patched with hide vacant tag, but I think I'm gonna unpatch it, because I was thinking on put the bar that you mentioned, but I don't know this kind of C source blow my mind I thin k Im not to prepare for that jajaja, but definitely I gonna make that. Thanks for share your knowledge.

Answer 33 · 2021-10-14T22:41:22.000Z

What is the name of the vacanttag patch you mentioned, now I want to make the line follow only the active window,

Answer 34 · 2021-10-15T00:54:03.000Z

It is hide vacant tags with some modification

Answer 35 · 2021-10-17T21:23:35.000Z

This is the result of your help, thank you for your time !. @fitrh

Answer 36 · 2021-10-24T08:56:48.000Z

@fitrh I made it, I kinda make a hybrid mode with rainbow tags and some of your knowledge. Here are the result of the tags :)

Hey @engjpacheco can you help me to get bar like yours (pacman)

Answer 37 · 2021-10-24T23:38:15.000Z

@yogeshdcool sure, what can I do for you?, The pacman icons are in the Material font. I only put them in my Xmenu icon (pacman), and the ghost is the icon of the stack style. The dots are the tags.

Answer 38 · 2021-10-26T03:47:39.000Z

@engjpacheco I need the colorfultags patch do you have it or did you applied it manually

Answer 39 · 2021-10-26T03:53:33.000Z

@yogeshdcool look, this is what I done:
1.-patch with the colorfultag patch.
2.-and add this to the dwm.c file:
in the drawbar(Monitor) function.

	w = TEXTW(tagtext);
	**drw_setscheme(drw, tagscheme[i]);**

Answer 40 · 2022-04-25T02:15:50.000Z

@engjpacheco cool, I suggest you to combined it with vacant tags, or even bar border, gap, and indictor and make it toggleable

simplescreenrecorder-2021-10-14_11.11.24.mp4

where can i find this bar border patch? it looks great

Answer 41 · 2022-04-25T07:34:54.000Z

@superstefan420 you can find the initial implementation in this commit

Answer 42 · 2022-09-18T17:52:05.000Z

Is this in a .diff file?

Answer 43 · 2022-09-18T23:47:28.000Z

@Spaxly not yet, but you can use the relevant commits as reference

Answer 44 · 2022-09-19T01:08:47.000Z

@fitrh Thanks.

Answer 45 · 2022-12-30T14:37:42.000Z

@fitrh thanks a lot for creating this very useful patch it is soo awesome ^_^ ... I Heavily appreciate your work .... works like a complete charm