Scripts are not running in PR's Checks

Question

Closed this issue 5 years ago · 7 comments

We need to run the scripts in PR's Checks and block PR unless all the checks pass.

Currently, PR don't have such a checks!

.. And even when running lint locally there's a bunch of errors that we could prevented by blocking PRs:

Answer 1 · 2020-05-20T22:12:19.000Z

Do you've the time to have a look @ealush ?

Answer 2 · 2020-05-20T22:19:55.000Z

Hm. Looks like stuff still run pretty well in ci. https://travis-ci.org/github/fiverr/passable

Things may have changed in the repo settings. Regarding the lint errors, they are there, but not blocking. You may ignore those.

Answer 3 · 2020-05-20T22:22:43.000Z

@sahariko Can you check the repository settings? I don't have permission for this

Answer 4 · 2020-05-20T22:23:07.000Z

Thanks @ealush ❤🌷

Answer 5 · 2020-05-26T15:35:45.000Z

@omrilotan This has been resolved. Right?

Answer 6 · 2020-05-26T15:37:45.000Z

I don't know, is it running correctly now?

Answer 7 · 2020-05-26T16:12:55.000Z

I see more checks in your PR (4 whereas I got 2), not sure if it got fixed totally.