fixstars/clpy

Test for ultima

LWisteria opened this issue · 6 comments

LWisteria commented

There is no test for ultima itself. That absence could be problem.

LWisteria commented

@vorj I request you to try this issue.

vorj commented

@LWisteria I made the template of test case for ultima in #202.
Then, what should we check? Please let me know your opinion.

These are the test cases what I conceived:

  • General conversions
    • Type cast
      • Function style cast
      • C++ cast
    • Constructor
    • Template instantiation
    • Overload mangling
    • Tricking half
  • Specific Conversions
    • CArray<T, N> to __global T*, CArray_N
    • Operator overloading for CArray
    • Member functions for CArray and CIndexer
    • Header name mutation
    • Begin/end print out directives
    • Elementwise/reduction kernel conversion
LWisteria commented

@vorj Firstly, do not send the big PR which contains whole cases. #202 (and a item you wrote above) is enough to merge. So please make those tests.

On the other hand, I will check the test cases, at latest before you finish the above cases.

LWisteria commented

Anyway, this issue is not on the beta2 milestone thus #153 's priority is higher.

vorj commented

OK, so I will create those test cases later.

LWisteria commented

@vorj The file for ultima test will be large. How about making ultima_tests directory and dividing them into each file by test type?

  • 👍1