Add ability to set custom port for validation/conversion webhooks
Closed this issue · 0 comments
yalosev commented
Ports for validation and conversion webhooks are hardcoded:
- https://github.com/flant/shell-operator/blob/main/pkg/app/webhook.go#L18
- https://github.com/flant/shell-operator/blob/main/pkg/app/webhook.go#L32
Have to add env variables VALIDATING_WEBHOOK_LISTEN_PORT and CONVERSION_WEBHOOK_LISTEN_PORT here:
- https://github.com/flant/shell-operator/blob/main/pkg/app/webhook.go#L39
- https://github.com/flant/shell-operator/blob/main/pkg/app/webhook.go#L70
use existing ports as default one.
P.S. Also can add _LISTEN_ADDRESS here