Fix remote shares access with GVFS 1.48

Question

Fix remote shares access with GVFS 1.48

Closed this issue 3 years ago · 9 comments

x80486 commented 3 years ago

Reference: flathub/flathub#2180

Answer 1 · 2021-03-29T02:38:54.000Z

How is it broken?

Answer 2 · 2021-03-30T13:01:01.000Z

It won't be able to talk to gvfsd, so everything that relies on gvfs won't work as expected.

Answer 3 · 2021-03-30T13:43:07.000Z

So all stuff like remote mounts and stuff like this, is that it?

From the linked report, all it takes is for us to add "--filesystem=xdg-run/gvfsd" to the list of permission, right? Then we'll have support for gvfs pre- and post-1.48?

Answer 4 · 2021-03-30T13:46:12.000Z

My question, is in which case does it fail? I couldn't find one, but it's totally possible that the problem is me here.

The original issue says not every app needs to do that:

If your application doesn't need to talk to gvfs via D-Bus, then it doesn't need access to xdg-run/gvfsd.

Answer 5 · 2021-03-30T13:49:43.000Z

So all stuff like remote mounts and stuff like this, is that it?

Yes, so pretty much required for an app like GIMP that doesn't use portals but wants to integrate into GNOME.

From the linked report, all it takes is for us to add "--filesystem=xdg-run/gvfsd" to the list of permission, right? Then we'll have support for gvfs pre- and post-1.48?

Yes.

The original issue says not every app needs to do that:

If your app doesn't talk to gvfs, then also remove all the org.gtk.vfs D-Bus holes that got punched.

In short, if you use a non-portal file chooser, then you want to punch all the holes necessary for gvfs so you can mount remote shares and disks.

Answer 6 · 2021-03-30T14:05:01.000Z

If your app doesn't talk to gvfs, then also remove all the org.gtk.vfs D-Bus holes that got punched.

Nono it does, since it was added as a response to someone asking for it: 8739c53 - issue #4372 in GIMP tracker

Anyway maybe we can't reproduce the issue if we don't use gvfs 1.48 yet. I assume it depends on the gvfs present on host-side, @hadess ? (here I have 1.46 on a Fedora 33)

Answer 7 · 2021-03-30T14:10:06.000Z

Anyway maybe we can't reproduce the issue if we don't use gvfs 1.48 yet. I assume it depends on the gvfs present on host-side, @hadess ? (here I have 1.46 on a Fedora 33)

It does, gvfs isn't installed inside the sandbox.

Answer 8 · 2021-03-30T14:16:33.000Z

Thanks @hadess.

@hfiguiere If you want to do your first direct commit, be my guest. 😉

Answer 9 · 2021-03-31T00:34:23.000Z

I see, given that I still run Fedora 33...