Toggling cellAspect ratio destroys items and layout?

[flekschas]

Commit or branch: master

Observed behavior:

• Upon disabling cellAspect all items disappear 😱
• When activating cellAspect: 1 again they reappear but are all positioned on top of each other 🤔
• Upon toggling of cellAspect all items disappear for good and never re-appear again 😞

Expected behavior:

• The items should not disappear and they should also not be positioned on top of each other

[eeeeenchanted]

I think the problem is solved now.

But if we disable both itemSize and columns then all things will disappear. I don't know whether we should fix this or not, since we said that one must provide itemSize or columns.

[flekschas]

Looks good. I think it is fine if everything disappears when itemSize and columns are null as this is an incorrect setting. We could, of course, disallow both from being null but that's not urgent. We should just need to make sure that when itemSize or columns is set again that the piles reappear :)

By the way, what was the issue that caused the piles to disappear permanently with the aspect ratio?

[eeeeenchanted]

Oh, it's because I didn't take care of the situation when rowHeight and cellAspectRatio are both null. Currently, if the grid system is incomplete, the piles would disappear for good 😂I'll try to fix this issue.

[eeeeenchanted]

I set the column number to 10 by default if both itemSize and columns are null, now the piles won't disappear.

Does it make sense?

[flekschas]

Yes, that sounds good :) Please either merge the fix right away or setup a PR

[eeeeenchanted]

I pushed to master already.