Toggling cellAspect ratio destroys items and layout?
Closed this issue ยท 6 comments
Commit or branch: master
Observed behavior:
- Upon disabling
cellAspect
all items disappear ๐ฑ - When activating
cellAspect: 1
again they reappear but are all positioned on top of each other ๐ค - Upon toggling of
cellAspect
all items disappear for good and never re-appear again ๐
Expected behavior:
- The items should not disappear and they should also not be positioned on top of each other
Looks good. I think it is fine if everything disappears when itemSize
and columns
are null
as this is an incorrect setting. We could, of course, disallow both from being null but that's not urgent. We should just need to make sure that when itemSize
or columns
is set again that the piles reappear :)
By the way, what was the issue that caused the piles to disappear permanently with the aspect ratio?
Oh, it's because I didn't take care of the situation when rowHeight
and cellAspectRatio
are both null
. Currently, if the grid system is incomplete, the piles would disappear for good ๐I'll try to fix this issue.
Yes, that sounds good :) Please either merge the fix right away or setup a PR
I pushed to master already.