Page scrolling to the top on load, even if an anchor is specified

[mquandalle]

When the Modal component is used, the page is scrolled to the top on first load, or during in-app navigation.
This is unwanted in case we link to an anchor.

Reproduction : https://repro-svelte-simple-modal-anchor-issue-maximequandalle.vercel.app/#anchor
Source : https://github.com/mquandalle/repro-svelte-simple-modal-anchor-issue/blob/master/src/routes/index.svelte

[mquandalle]

It seems that this bug was introduced in #31.

[flekschas]

Sorry for the glitch and thanks for reporting the issue. Can you test it with the following version of the Modal?

https://svelte.dev/repl/2eb021eff87d45019549565136b0e6ed?version=3.44.1

In my local tests with your repo this fixes the issue.

[mquandalle]

Yes it fixes the issue.

The problem was indeed the reactivity of isMounted variable in the following block, causing close() to be called on mount:

svelte-simple-modal/src/Modal.svelte

Lines 201 to 219 in 43bb9c1

	let isMounted = false;
	$: {
	if (isMounted) {
	if (isFunction(show)) {
	open(show);
	} else {
	close();
	}
	}
	}
	svelte.onDestroy(() => {
	if (isMounted) close();
	});
	svelte.onMount(() => {
	isMounted = true;
	});

[flekschas]

New version with a fix is out

[mquandalle]

Thank you for the quick fix!