Still tons of references to `params` in task files, even after we've flattened the task JSON
dzwillia opened this issue · 1 comments
dzwillia commented
Just do a search on 'params' in the flexio-sdk-js repo. Results are everywhere.
Any call to _.get(json, 'params', json)
has got to go -- there's no need to use _.get()
in any of these scenarios anymore since we've flattened the JSON. The json
parameter that is passed in does need to be deep cloned, however, if it is going to be mutated at all.
I've attached a file with all of the references I could find to 'params' in the task files.
biwillia commented
This is by design. It will go, but it's meant to be temporarily backward-compatible with the old format.