flexn-io/renative

Cannot contribute to this excellent project!

Opened this issue · 0 comments

gaurav21r commented

🔥Thank you for this fantastic project @pavjacko @mihaiblaga89 @aurimasmi

We use React Native at my workplace and the team's interested in using Renative to make WearOS & Android TV apps. There's a small issue with supporting older versions of WearOS (that still have a signficant Market share but unfortunately due to Google's early wearables strategy, most devices can't be upgraded)

The problem is renative doesn't recognize some of these devices at the point where it searches for devices & emulators and we've found the lines of code that need to be changed exactly!

renative/packages/sdk-android/src/deviceManager.ts

Line 280 in 435ccd3

const decideIfWearRunning = async (c: RnvContext, device: AndroidDevice) => {

We've followed the rules as given in

renative/CONTRIBUTING.md

Line 1 in 435ccd3

# Contributing to ReNative

I am new to monorepos so please forgive any newbie mistakes, here are some issues:

  1. The canary branch mentioned here doesn't seem to exist, we used main and the latest release branches instead.
  2. After making a change we ran yarn build in packages/cli but got the error: Cannot find @rnv/core
  3. We then went into the root of the mono repo and ran yarn build for a long time any change we made would not get built and would fail at the packages/sdk-android package.
  4. Somehow we got our changes built (I think we did a yarn compile first). Maybe add additional steps to CONTRIBUTING.md ?
  5. We then went into the folder of an app previously scaffolded using npx rnv new and ran our version of the CLI using node ~/htdocs/renative-forked/packages/cli/lib/bin.js run -p androidwear but that gave us an error about Double @rnv/core detected.
  6. We then tried to scaffold a new App using our CLI using node ~/htdocs/renative-forked/packages/cli/lib/bin.js new. We then got these errors:
Image Image

We've noticed in

renative/CONTRIBUTING.md

Line 45 in 435ccd3

2. Make the desired changes to ReNative sources. Use the `packages/template-starter` and `packages/template-hello-blank` app to test them out.

But aren't they just templates? Which get copied over while scaffolding? Please guide us in the right direction, @ElenaDiachenko and @Marius456 All we want to do is to make some changes to the repo and then use those changes to run the emulator / scaffold etc instead of the npm version.

If this is solved, The whole team would love to contribute a lot more to this project!