flexn-io/renative

File overrides not applied consistently on 1.10.0-rc.1

Opened this issue · 2 comments

CHaNGeTe commented

Describe the bug
Overrides are not applied consistently on 1.10.0-rc.1
I see the overrides system changed a bit, now they are tracked in .rnv/overrides. And sometimes are applied, but for example after an install operation, a next npx rnv run.... will not apply the overrides properly, at least for file based ones.

To Reproduce
Steps to reproduce the behavior:

  • Use 1.10.0-rc.1
  • Have file overrides on a plugin
  • npx run ... -> applied correctly (generates .rnv/overrides properly)
  • remove node_modules and install (yarn / yarn bootstrap / whatever)
  • npx run ... -> overrides not applied correctly

Expected behavior
Overrides applied when needed. New install operations also should trigger the override system.
Without git clean or whatever, a normal install operation should tell the override system that needs to reapply.

Workaround:

  • Remove .rnv/overrides
  • npx run ... again

Screenshots or copy&paste
If applicable, add screenshots to help explain your problem.
If applicable, copy&paste the output of the command. Run the command with -i to get more debugging informations

Desktop (please complete the following information):

  • OS: [e.g. osx, windows 7, ubuntu 16.04] Mac OsX 15.6.1
  • Node Version [e.g. v10.16.3] v23.8.0
  • RNV Version [e.g. 0.25.0] 1.10.0-rc.1

Additional context
I know it is a RC but just so you know ;)

CHaNGeTe commented

btw have you ever considered patch-package as system for overrides?