floccusaddon/floccus

WebDAV lock not removed after 30 min; icon doesn't indicate a problem

Closed this issue · 5 comments

Which version of floccus are you using?

5.0.10

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Brave

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

To/From my Fastmail account

Describe the Bug

I have Brave syncing it's tabs to a profile. This is the only browser using this profile - it's not shared.
Somehow a .lock file appeared for this profile from a previous day. Upon waking up, floccus tried to sync, and continues to wait. it's been over an hour.

Does the lock removal code work for WebDAV? These shouldn't last this long, should they?

I did restart my browser and the .lock file is still there.

Related, the plugin icon in the browser bar is in the OK state. It should probably be in the X state indicating at least one profile error.

Expected Behavior

Lock file to be removed after half hour (per online docs)

To Reproduce

Set up a profile to sync tabs to a webDAV source
Generate or capture a lock file
Copy captured file to block a sync
Attempt a sync for this profile
// This profile will be synced soon. We're waiting for other devices of yours, or other profiles to this device to finish syncing
// after 30 mins pass, the lock file should be removed with a sync
// icon should show an X if any profile isn't working

Debug log provided

  • I have provided a debug log file

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

In v5.x this has been increased to 2h. If it still isn't removed after that, this is a great find as so far I've assumed this symptom stems from multiple browsers consecutively locking each other out, but if you only have one browser, there might be a different reason for this. this might be a duplicate of #1548

Hello @andbenn

Did this resolve itself by now?

Hi @marcelklehr . I let the lock exist and go for several days and the lock was not released. I ended up deleting the .lock file for that profile from my folder view on the host of my webdav files (Fastmail). I have not need it since, knock on wood.

Mmh. Weird that it would not clear that up on its own... Closing this then for now. Feel free to shout here or open a new issue if this should resurface.