floccusaddon/floccus

Cannot request origin permission for *://*/* since it was not declared in the manifest

Closed this issue · 11 comments

Which version of floccus are you using?

5.0.10

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Librewolf 122.0.1

Which version of Nextcloud Bookmarks are you using? (if relevant)

13.1.3

Which version of Nextcloud? (if relevant)

28.0.4

What kind of WebDAV server are you using? (if relevant)

N/A

Describe the Bug

When trying to add a profile I type in my server name https://cloud.mysite.com but I get the following error and cannot proceed

Cannot request origin permission for :///* since it was not declared in the manifest

Expected Behavior

I would expect to move on to enter my username and password and be able to create the profile

To Reproduce

Install Floccus
Try to create profile
Enter https URL
Observe error

Debug log provided

  • I have provided a debug log file

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

Possibly related. In the extensions debug window there is a warning on the Floccus extension which may be related

Reading manifest: Warning processing browser_action.chrome_style: An unexpected property was found in the WebExtension manifest.

I am getting the identical error using Mullvad Browser. Posting my specs below:

Which version of floccus are you using?

5.0.10

Sync method

Nextcloud Bookmarks

Which browser are you using?

Mullvad Browser 13.0.13 (based on Mozilla Firefox 115.9.1esr)

Which version of Nextcloud Bookmarks are you using? (if relevant)

13.1.3

Which version of Nextcloud? (if relevant)

Nextcloud Hub 5 (27.0.2)

To clarify, the same error appears if trying to use WebDAV as well. It seems it is not strictly related to the sync method, but rather the way requests are made.

Both Librewolf and Mullvad are security-focused browsers based on Firefox, so there may be some commonality there

It seems this may be related
https://www.extension.ninja/blog/post/solved-only-permissions-specified-in-the-manifest-may-be-requested/

Been conducting some tests with building the xpi locally, and replacing inside the various manifest files *://*/* with <all_urls> and even explicitly the actual domain name of my server. The error code remains the same, which baffles me...

There seems to be a file called \dist\js\options.js that is automatically generated when building. It has a segment

await s.default.permissions.request({origins:["*://*/*"]})

and this does not seem to change, even when modifying the manifests.

On a side-note @mattdale77, a work-around that I was able to do for Mullvad Browser was to correctly configure a profile on a "vanilla" Firefox; export, then import that profile into Mullvad. Note: this will expose your password in plaintext in the exported json file...

aaah. I think I've found the culprit. What's the user agent string of mullvad / librewolf?

aaah. I think I've found the culprit. What's the user agent string of mullvad / librewolf?

After reading this, I was like “OMG, all I had to do was turn off my User Agent Switcher add-on on Firefox.” But no, that did not work.

I can confirm that Floccus is working perfecly on Librewolf, but not on my hardened Firefox.

@nilsjor

a work-around that I was able to do for Mullvad Browser was to correctly configure a profile on a "vanilla" Firefox; export, then import that profile into Mullvad.

I tried something similar. I configured the profile on Android and then imported it to my hardened Firefox successfully. However, synchronisation is not working. It is stuck. Probably because it is throwing the same error in the background or something.

aaah. I think I've found the culprit. What's the user agent string of mullvad / librewolf?

For Mullvad, it's the same at the Tor Browser.

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

this does not seem to change, even when modifying the manifests.

You will need to adjust the code in the source files as well (in src/, you can grep for the line, it's the same line)

I can confirm the behavior. I'm not sure if it's a bug or a feature, but either way it's most likely an issue with mullvad/librewolf. You may want to open an issue over at mullvad github.com/

You can tell them that we get the error, even though the URL is set in the manifest.