flow/flow-for-vscode

Release 1.8.0 missing code

jdlm-stripe opened this issue · 9 comments

About an hour ago it looks like versions 1.7.0 and 1.8.0 were released but they appear to be missing the build dir with code. I suspect it was just a failed publish or something like that. 1.5.0 seems like the last good version.

Hi, thanks for raising this. My mistake, looking into it

I just published 1.9.0 to fix this, let me know if it works properly for you

I was just on v1.9.0 and there's still and issue, flow isn't able to start on vscode and there's nothing in the status bar now

noppa commented

@Brianzchen Weird, 1.9.0 works for me

@Brianzchen to help me determine what the issue may be, could you let me know what output you see when you set Settings->Flow Configuration->Flow: Log Level to trace then open View->Output and select Flow from the dropdown menu on the Output pane, and open VSCode to a Flow project.

@vrama628 double checked I'm on 1.9.0 and definitely doesn't work. My issue that I can't even start flow at all on vscode. Notable things on the screenshot,

  • version is on 1.9.0
  • there is no flow status on bottom
  • updated to trace
  • flow is not in the dropdown
  • I can't even manage to start flow or run any commands

Screen Shot 2021-07-01 at 8 32 43 am

Also if it makes and difference I'm running flow 0.154.0

1.9.0 is working for us now but I saw a weird issue that magically went away for me today. I think the bundled version of Node that comes with VSCode wasn't new enough to have a new addition of fs/promises which was added in 1.9.0. I suspect folks might be running into the same issue.

Yesterday when I was debugging the issue I was seeing node 12.x.x throwing an error while trying to require('fs/promises') but for some reason today node 14.x.x is bundled with my vscode. I must have just gotten a background update that fixed it.

TL;DR: try updating VSCode and this extension to 1.9.0. I'm going to close this issue since it appears fixed.

Yes just updated my vscode and it works! Thanks @jdlm-stripe

mroch commented

00a4ff0 (released as 1.9.1) should restore compatibility with older versions of VS Code. nice find!