Syntax highlighting?
Closed this issue · 5 comments
I would love it if the type annotations adopted the current colorscheme's comment color. Currently, it feels quite cluttered, and it's sometimes hard to see what is Flow and what is not.
I'm thinking this isn't really the right repo for this, but couldn't find a better one and I haven't had time to give it a shot myself, but I'm hoping someone here will see it and either implement it here or separately.
Some good starting points might be reading Writing Vim Syntax Plugins and Creating your own syntax files, and looking at repos like vim-jsx, vim-javascript, and vim-es6 since they seem to do a similar thing as would be desired here, i.e., extending the base JavaScript syntax.
@achao I'm not sure if its needed since the vim-javascript you linked already has full support for it.
See https://github.com/pangloss/vim-javascript#configuration-variables
let g:javascript_plugin_flow = 1
Would you look at that! Thank you :)
the issues are piling up as only one person contributes to flow support at vim-javascript. arguably, vim-javascript has no business providing full flow support. one recent example: https://github.com/pangloss/vim-javascript/issues?utf8=✓&q=label%3Aflow%20
edit:
only one person, @amadeus , contributes to flow syntax highlighting. I also add flow specific logic to the indent script there
I use flow at my work, but I don't actually have a very deep knowledge of it. I could definitely use help from someone who has a deep understanding of its intricacies, because I think it could help clean up a lot of the small bugs it has, if only I knew the flow specific rules for things.
not a vim expert ... so I don't think I can help here but it's painful not having syntax highlighting and folding on flow ... but I am doing opensource full time ... currently trying to contribute to react-native
I can not multitask too much
Becoming very improducting, I wasted 2 hours this morning to figure this out