flowgrammable/flowsim

Trace controller doesnt update on switch deletion

Closed this issue · 4 comments

Trace controller doesnt update on switch deletion
  1. Create a packet, profile, switch, and trace
  2. Delete the switch
  3. Click on simulation ... switch is still there ...

Obvious question is ... what should behavior be, if you delete a switch out from under a simulation. Right now the switch is just a reference, but should it be a copy, or should we just clear the trace data set on delete.

After deleting the switch did you save? Yes or no

On Tue, Feb 10, 2015 at 12:31 PM, Jasson Casey notifications@github.com
wrote:

  1. Create a packet, profile, switch, and trace
  2. Delete the switch
  3. Click on simulation ... switch is still there ...


Reply to this email directly or view it on GitHub
#146 (comment)
.

No save.

On Tue, Feb 10, 2015 at 10:54 AM, Colton Chojnacki <notifications@github.com

wrote:

After deleting the switch did you save? Yes or no

On Tue, Feb 10, 2015 at 12:31 PM, Jasson Casey notifications@github.com
wrote:

  1. Create a packet, profile, switch, and trace
  2. Delete the switch
  3. Click on simulation ... switch is still there ...


Reply to this email directly or view it on GitHub
<
https://github.com/flowgrammable/flowsim/issues/146#issuecomment-73754895>
.


Reply to this email directly or view it on GitHub
#146 (comment)
.

In UI-state branch I have modified behavior to be the following:

  • Deleting a packet or switch outside of the simulation view will result in the asset being removed from the trace
  • Leaving the simulation screen will stop any simulation already in progress. This is a temporary fix to reduce erratic behavior with deleting switches, packets, etc. Ideally a user should be able to insert a flow during a simulation, but a user should not be able to delete the switch that is currently being used in the simulation. The simulation & switch config view need to be reworked so that a user can insert flow during simulation, but not be able to delete the switch