flr/FLBEIA

advSum providing incorrect response

pdolder opened this issue · 1 comments

pdolder commented

Hi,

I just noticed that the advSum function provides discards in both the landings and the discards slot. It can be traced here:

FLBEIA/R/Results_Summary.R

Line 1724 in 3946e10

res <- as_tibble(cbind(x1,discards = x3[,4], landings = x3[,4]))

Assume landings should be x3[, 3]

ssanchezAZTI commented

Hi Paul,

Thank you for noticing the error!

However, landings are calculated in x2, so the correction should be:
res <- as_tibble(cbind(x1,discards = x3[,4], landings = x2[,4]))

Now is fixed!

Best regards,
Sonia