fluencelabs/nox

fluence-fork-libp2p bad dependencies

Closed this issue · 13 comments

https://crates.io/crates/fluence-fork-libp2p/0.36.2/dependencies

https://crates.io/crates/fluence-fork-libp2p-websocket/0.28.1/dependencies
https://crates.io/crates/soketto/0.4.2/dependencies

https://crates.io/crates/fluence-fork-libp2p-gossipsub/0.29.1/dependencies

see base64 0.12 and 0.13.

this makes build of chef fail

INFO[1653] Running: [/bin/sh -c cargo chef cook --check --tests --all-targets --recipe-path recipe.json] 
error: failed to parse lock file at: /Cargo.lock
Caused by:
  package `base64` is specified twice in the lockfile
folex commented

@dzmitry-lahoda can you please revert to a working Cargo.lock and avoid doing cargo update?

We'll move to vanilla libp2p at some point and this issue would be resolved automatically.

oh sure, so fluence-keypair is unusable on chain in mono repo. cannot compile. so will not be able validates keys in monorepo.

folex commented

@dzmitry-lahoda can you please explain what do you mean by 'unusable'? Why can't you use it?

I've set up a simple project that uses fluence-keypair https://github.com/folex/keypair-test, please check it out

if i reference it, i cannot assemble all roots packages via chef. i mean i cannot reference anyrhing libp2p fluence forget in monorepo. may have to do it not monorepo or condition chef better, or ask chef to fix it working in rhis case. but problem when i add this, i fail compile cache to speed up ci tests.

unsuable in monorepo with ci cache.

folex commented

@dzmitry-lahoda I can't follow your flow. Can you please give me a link to a minimal project that reproduces the problem?

i have this issue LukeMathWalker/cargo-chef#43 (comment) . and need to find work around

I can't follow your flow. Can you please give me a link to a minimal project that reproduces the problem?

So problem is that if I try to use chef with repo using all up to date fluence crates withing wasm and non wasm projects and tests, I cannot build cache with tool to speed up CI. Actually it is one of reasons why CI is slow - it compiles several hierarchies of crates.

folex commented

Can you please give me something to reproduce or see in action? It's hard to help better without anything palpable...

folex commented

@dzmitry-lahoda any updates? how to reproduce your problem?

will share cargo chef example. but issue also in inability to use libp2p wasm in services.

folex commented

Please share a step-by-step instructions on how to reproduce the issue. I've no experience with cargo chef, but I've got experience debugging different Cargo issues. To be able to debug and diagnose, I need to be able to run it.

folex commented

not enough info