fluidex/dingir-exchange

Broken: Adding new assets and markets over the REST API

gcomte opened this issue · 1 comments

gcomte commented

The test examples/js/tests/set_markets.ts doesn't run through.
It is broken on many levels:

  • The constants new_asset as well as new_market1 and new_market2 in the file examples/js/tests/set_markets.ts need additional arguments to fit the REST interface (See structs NewAssetReq and NewTradePairReq in file src/restapi/types.rs for more details.
  • The base and quote attribute for a new market needs to be a string rather than an object (eg. base: "BTC", rather than base: { name: "BTC", prec: 2 },)
  • The new asset-call does not persist for some reason, without throwing any error. Maybe it is because of the on conflict do nothing-part in the file src/storage/config.rs (function persist_asset_to_db)
  • ... might require additional fixes
HAOYUatHZ commented

Thanks for reporting the bug, we will look into it!

  • 👍1