fluttercandies/extended_text

[Bug report] build error with flutter 3.10.0

Closed this issue · 6 comments

Version

10.0.1

Platforms

dart

Device Model

iPhone 12(iOS 14)

flutter info

[✓] Flutter (Channel stable, 3.10.0, on macOS 13.3.1 22E772610a darwin-x64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] IntelliJ IDEA Community Edition (version 2023.1.1)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

How to reproduce?

build error with flutter 3.10.0

Logs

[+1751 ms] [+2064 ms] ../../.pub-cache/hosted/pub.dev/extended_text-10.0.1/lib/src/selection/extended_text_selection.dart:151:7: Error: The non-abstract class 'ExtendedTextSelectionState' is missing implementations for these members:
[   +1 ms] [   +2 ms]  - TextInputClient.insertContent
[        ] [        ] Try to either
[        ] [        ]  - provide an implementation,
[        ] [        ]  - inherit an implementation from a superclass or mixin,
[        ] [        ]  - mark the class as abstract, or
[        ] [        ]  - provide a 'noSuchMethod' implementation.
[        ] [        ] class ExtendedTextSelectionState extends State<ExtendedTextSelection>
[        ] [        ]       ^^^^^^^^^^^^^^^^^^^^^^^^^^
[        ] [        ] ../../flutter/packages/flutter/lib/src/services/text_input.dart:1117:8: Context: 'TextInputClient.insertContent' is defined here.
[        ] [        ]   void insertContent(KeyboardInsertedContent content) {}
[        ] [        ]        ^^^^^^^^^^^^^
[        ] [        ] ../../.pub-cache/hosted/pub.dev/extended_text_library-10.0.0/lib/src/selection/extended_text_selection.dart:364:18: Error: The argument type 'void Function(TapDownDetails)' can't be assigned to the parameter type 'void Function(TapDragDownDetails)?'.
[        ] [        ]  - 'TapDownDetails' is from 'package:flutter/src/gestures/tap.dart' ('../../flutter/packages/flutter/lib/src/gestures/tap.dart').
[        ] [        ]  - 'TapDragDownDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart').
[        ] [        ]       onTapDown: onTapDown,
[        ] [        ]                  ^
[        ] [        ] ../../.pub-cache/hosted/pub.dev/extended_text_library-10.0.0/lib/src/selection/extended_text_selection.dart:369:22: Error: The argument type 'void Function(TapUpDetails)' can't be assigned to the parameter type 'void Function(TapDragUpDetails)?'.
[        ] [        ]  - 'TapUpDetails' is from 'package:flutter/src/gestures/tap.dart' ('../../flutter/packages/flutter/lib/src/gestures/tap.dart').
[        ] [        ]  - 'TapDragUpDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart').
[        ] [        ]       onSingleTapUp: onSingleTapUp,
[        ] [        ]                      ^
[        ] [        ] ../../.pub-cache/hosted/pub.dev/extended_text_library-10.0.0/lib/src/selection/extended_text_selection.dart:374:24: Error: The argument type 'void Function(TapDownDetails)' can't be assigned to the parameter type 'void Function(TapDragDownDetails)?'.
[        ] [        ]  - 'TapDownDetails' is from 'package:flutter/src/gestures/tap.dart' ('../../flutter/packages/flutter/lib/src/gestures/tap.dart').
[        ] [        ]  - 'TapDragDownDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart').
[        ] [        ]       onDoubleTapDown: onDoubleTapDown,
[        ] [        ]                        ^
[        ] [        ] ../../.pub-cache/hosted/pub.dev/extended_text_library-10.0.0/lib/src/selection/extended_text_selection.dart:375:29: Error: The argument type 'void Function(DragStartDetails)' can't be assigned to the parameter type 'void Function(TapDragStartDetails)?'.
[        ] [        ]  - 'DragStartDetails' is from 'package:flutter/src/gestures/drag_details.dart' ('../../flutter/packages/flutter/lib/src/gestures/drag_details.dart').
[        ] [        ]  - 'TapDragStartDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart').
[        ] [        ]       onDragSelectionStart: onDragSelectionStart,
[        ] [        ]                             ^
[        ] [        ] ../../.pub-cache/hosted/pub.dev/extended_text_library-10.0.0/lib/src/selection/extended_text_selection.dart:376:30: Error: The argument type 'void Function(DragStartDetails, DragUpdateDetails)' can't be assigned to the parameter type 'void Function(TapDragUpdateDetails)?'.
[        ] [        ]  - 'DragStartDetails' is from 'package:flutter/src/gestures/drag_details.dart' ('../../flutter/packages/flutter/lib/src/gestures/drag_details.dart').
[        ] [        ]  - 'DragUpdateDetails' is from 'package:flutter/src/gestures/drag_details.dart' ('../../flutter/packages/flutter/lib/src/gestures/drag_details.dart').
[        ] [        ]  - 'TapDragUpdateDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart').
[        ] [        ]       onDragSelectionUpdate: onDragSelectionUpdate,
[        ] [        ]                              ^
[        ] [        ] ../../.pub-cache/hosted/pub.dev/extended_text_library-10.0.0/lib/src/selection/extended_text_selection.dart:377:27: Error: The argument type 'void Function(DragEndDetails)' can't be assigned to the parameter type 'void Function(TapDragEndDetails)?'.
[        ] [        ]  - 'DragEndDetails' is from 'package:flutter/src/gestures/drag_details.dart' ('../../flutter/packages/flutter/lib/src/gestures/drag_details.dart').
[        ] [        ]  - 'TapDragEndDetails' is from 'package:flutter/src/widgets/tap_and_drag_gestures.dart' ('../../flutter/packages/flutter/lib/src/widgets/tap_and_drag_gestures.dart').
[        ] [        ]       onDragSelectionEnd: onDragSelectionEnd,
[        ] [        ]                           ^

Example code (optional)

No response

Contact

No response

I see the fix is merged, any comment on when we'll get a version bump in pub.dev? cc @zmtzawqlp

I see the fix is merged, any comment on when we'll get a version bump in pub.dev? cc @zmtzawqlp

There is still a lot of other work to be done, so wait for the author.

I see the fix is merged, any comment on when we'll get a version bump in pub.dev? cc @zmtzawqlp

There is still a lot of other work to be done, so wait for the author.

Flutter 3.10 / Dart 3.0 specific work? Would simply be nice to unblock this package users from being able to upgrade to flutter 3.10.

I see the fix is merged, any comment on when we'll get a version bump in pub.dev? cc @zmtzawqlp

There is still a lot of other work to be done, so wait for the author.

Flutter 3.10 / Dart 3.0 specific work? Would simply be nice to unblock this package users from being able to upgrade to flutter 3.10.

@alarkirikal Flutter changes too much, the author may need to refactor this release :)