flutterjanus/flutter_janus_client

Cant use RTCIceServer without credential/password

Closed this issue · 2 comments

Clon1998 commented

Hey,
the current implementation of your RTCIceServer class contains a bug that causes an issue on the native side while building the peerconnection.

In particular, it is impossible to add/use Ice candidates that do not enforce a username/credential as the toMap() method will include these fields with values null when submitting the init request to the platform code.

shivanshtalwar commented

You are right it can be easily solved, by adding a null check in toMap would you like to do a pr for the same?

  • 👍1
Clon1998 commented

You are right it can be easily solved, by adding a null check in toMap would you like to do a pr for the same?

Just created the PR