flutterjanus/flutter_janus_client

apiSecret not working

baihua666 opened this issue · 6 comments

baihua666 commented

version: janus_client: 2.2.1
line 155 of file janus_client.dart ,
constructor of JanusClient
change
_apiSecret = _apiSecret;
to
_apiSecret = apiSecret;

shivanshtalwar0 commented

Maybe you can release a pr for the same to help me fix it

baihua666 commented

OK，I also found some other issue that can be submitted together，video call plugin does not handle error events such as the registered username already exists
I'll make a pr later

shivanshtalwar0 commented

Awesome 👍! Thanks will add you into contributors after the pr review

shivanshtalwar0 commented

Could you please add same error handling for other plugins as well?

baihua666 commented

ok i'll try it, but i don't know how other plugins work and probably won't be able to test it