flux-iac/tofu-controller

Helm template fails for v0.16.0-rc.4 when you specify imagePullSecrets

ayanevbg opened this issue · 4 comments

ayanevbg commented

When you specify custom imagePullSecrets the chart fails to render.

This is because a secret was added in runner-serviceaccount.yaml but the end block for the {{- with $.Values.imagePullSecrets }} statement is after the Secret.

Should be easy fix by moving one of the {{- end }} af the end of the file to line 18.

imagePullSecrets:
{{- toYaml . | nindent 2 }}
{{- end }}

ayanevbg commented

It seems that the same version is pushed for chart v0.16.0-rc.3. Although the code for this version says otherwise - https://github.com/flux-iac/tofu-controller/blob/v0.16.0-rc.3/charts/tf-controller/templates/runner-serviceaccount.yaml

  • 👍1
chanwit commented

Thank you @ayanevbg would you mind put up an PR for it so I could help review this quickly?

ayanevbg commented

Thank you @chanwit . I put up an PR - #1251

chanwit commented

Fantastic!!
Thank you so much for the PR.

Will re-release the helm chart to address this issue today.