fluxcd-community/helm-charts

When notification controller is disabled events-addr should be set us false to avoid POST API calls

suryapandian opened this issue · 0 comments

Describe the bug a clear and concise description of what the bug is.

We use just the kustomize-controller and source-controller, and we have disabled notifications controller.
however, event-addr has a default value which is rendered

Hence, the logs are populated with the error

POST http://notification-controller/ giving up after 5 attempt(s): Post \"http://notification-controller/\": dial tcp: lookup notification-controller on 169.254.20.10:53: no such host

As a fix, we can set event-addr to empty string when notification-controller is set as false

What's your helm version?

3.8.2

What's your kubectl version?

1.24.1

What's the chart version?

1.4.0

What happened?

Kustomize controller tried to make post call to notification controller even though notification controller did not exist.

What you expected to happen?

kustomize controller should not try making the API call to notification controller when notification controller does not exist.

How to reproduce it?

Disable notification controller and run with just source and kustomize controller.

Enter the changed values of values.yaml?

set notification controller as false

Enter the command that you execute and failing/misfunctioning.

kubectl logs of kustomize controller.

Anything else we need to know?

No response