fluxcd/flagger

Traffic Policy seems to be out of date from the latest istio configuration

Closed this issue · 0 comments

andmeek commented

Describe the feature

I need to be able to properly enable locality base routing weights and failover which must be done in the DestinationRule https://istio.io/latest/docs/reference/config/networking/destination-rule/#LocalityLoadBalancerSetting-Distribute and in general have more control of the output destination rule as istio will only honor one DR for the targeted host so I can't just add another one separately.

Separately requiring simple to be set always does not match the istio DR definition.

Proposed solution

I'm not 100% sure I have enough context to say the best ideal approach that lines up with the long term goals of the project but here's a few ideas:

  1. Add missing CRD fields to the canary object to pass through
  2. Add configuration to disable DestinationRule generation
  3. Source CRD definition from istio repositories automatically via CI instead of copy pasting it here

Any alternatives you've considered?

Not use flagger? I don't see a way with the current configuration options to control this.