fly-apps/live_beats

Cannot upload MP3 without ID3 tags

colinstark opened this issue · 2 comments

colinstark commented

Hello 👋
Tried uploading an MP3 (17.6mb) that I converted from WAV with Firefox 96.0.3 on macOS, it stopped in the middle of the upload process:

no-valid-mp3

after adding ID3 for artist & title and re-exporting, it worked. Is checking for valid ID3 tags part of the upload validation check? If so, can the app display what is wrong with the file?

chrismccord commented

We don't necessary require the ID3 tags, but our parser may not be taking into account some encodings. If you're able, you could try running locally and see what either of these clauses get angry about https://github.com/fly-apps/live_beats/blob/master/lib/live_beats/mp3_stat.ex#L57-L61

  • 👍1
colinstark commented

fixed in #44 :)