Don't require deadline for deletion of backups
Opened this issue · 3 comments
The deletion of the oldest backup when reaching the Maximum number of packages-number is only executed when the Remove backup packages older than-deadline is also set, this is not mentioned anywhere and also not desirable. This could easily be fixed by removing || empty($deadline) from line 202 of FTPClient.php and adding an empty($deadline)-check around the second half of line 225.
@tobisalad thanks for the comment.
I can remember a discussion from 2017 with @adrianbj about this subject.
I need to check the code and the commits and I will be back to this issue. Can you confirm you are on the very last version ?
Do you spotted if It happen only when using FTP mode ?
Stay tuned.
It says that I'm on version v1.4.21, which I believe is the latest, I also checked in this repository and the code is the same here.
It correctly deletes backups when using local storage (though not the respective log-files, which is a separate issue).
Ok thank you. I don't remember right now why I coded this feature to only works when the setting Local Folder in ON.
I will check it and will also fix the log deletion.