flyemsafe/qubinode-installer

[BUG] Installer fails to set lvm flag to no if no NVME devices are found on the underlying hardware

joecharles33 opened this issue · 0 comments

Describe the bug
[BUG] Installer fails to set lvm flag to no if no NVME devices are found on the underlying hardware, also there's a redundant step with the idm configuration portion of the installer.

Screenshots




    ****************************************************************************
    The default product option is to install Red Hat Openshift Container
    Platform (OCP). An subscription for OCP is required. If you do not have an
    OCP subscription. Please display the menu options for other product
    installation such as OKD. The OCP cluster deployment consist of:

      - 1 IDM server for DNS
      - 1 Master node
      - 2 App nodes
      - 2 Infra nodes

    Gluster is deployed as the container storage running on the infra and app
    nodes.

    If you wish to continue with this install choose the **continue** option
    otherwise display the help menu to see the available options.
    ****************************************************************************

1) Continue with the default installation
2) Display other options
#? 1


 *************************
 * Deploying OpenShift 3 *
 *************************


 Please supply root password for the following command: su -c "test -f /etc/sudoers.d/joe"
Password: 

Setting up /etc/sudoers.d/joe Please supply root password for the following command: su -c "cp /tmp/tmp.HZhD53Ssse /etc/sudoers.d/joe"
Password: 
chmod: cannot access ‘/etc/sudoers.d/joe’: No such file or directory



    ***************************
    *   Interactive Session   *
    ***************************

 If you've made an mistake you can restart the install by
 hitting Ctrl-c then running ./qubinode-installer -m clean.
 This will remove all configuration data


        **NOTICE**
 Did not find a NVME device

 Qubinode recommends using a NVME device for
 storing the VMs disk. The device will be paritioned and
 a LVM volume created and mounted to /var/lib/libvirt/images.

 No additional storage device found.

 You can skip this and use the default
 disk where /var/lib/libvirt/images is mounted.

Do you want to skip configuring additional storage? yes/no yes

 Setting create_lvm to no.

```sed: can't read : No such file or directory```
 Enter your dns domain or press [ENTER] for the default [lab.example]: 
 Your username joe will be used to ssh into all the VMs created.

 Next we will need the password for this use. When entering the password, do not Backspace.
 Just Ctrl-c to cancel then run the installer again.

 Enter a password for joe [ENTER]: **********

 Red Hat Subscription Manager Credentials
 ****************************************
 Your credentials for access.redhat.com is needed.

 This is use to register this instance of RHEL and
 along with the other RHEL vms that will be deployed.
 There are two types of credentials:
   (*) activation key
   (*) username/password

 The username/password is what's more commonly use.
 The activation key is commonly use with a Satellite server.

 Which option are you using to register the system?
1) Activation Key
2) Username and Password
#? 2
 Enter your RHSM username and press [ENTER]: 
 Enter your RHSM password and press [ENTER]: 

    Red Hat Identity Management (IdM)
    *********************************

 The Qubinode depends on IdM as the DNS server.
 To provide DNS resolutions for the services deployed.
 The installer default action is deploy a local IdM server.
 You can also choose to use an existing IdM server.

 Would you like to use an existing IdM server? yes/no no
 The IdM server will be assigned a dynamic ip address from
 your network. You can assign a static ip address instead.

 Would you like to assign a static ip address to the IdM server? yes/no yes

 Enter the ip address you would like to assign to the IdM server: 192.168.x.x
 You entered 192.168.4.81, is this correct? yes/no yes
 The qubinode-installer will connect to the IdM server on 192.168.x.x
 Enter a password for the IDM server console and press [ENTER]: **********



    ***************************
    *   Setup is complete   *
    ***************************

 kubenode.lab.example is already registered


    *********************************
    *   RHSM registration complete  *
    *********************************

Error: '' does not match a valid repository ID. Use "subscription-manager repos --list" to see valid repositories.
Repository 'rhel-7-server-ansible-2.6-rpms' is enabled for this system.
Package git-1.8.3.1-20.el7.x86_64 already installed and latest version
 Create ansible-vault password file /home/joe/.vaultkey
 Downloading required roles


    *******************************
    *   Ansible Setup Complete   *
    *******************************



***************************
* Running qubinode perquisites *
******************************

 Please supply root password for the following command: su -c "test -f /etc/sudoers.d/joe"
Password: 

 joe is setup for password-less sudo


    ***************************
    *   Interactive Session   *
    ***************************

 If you've made an mistake you can restart the install by
 hitting Ctrl-c then running ./qubinode-installer -m clean.
 This will remove all configuration data


        **NOTICE**
 Did not find a NVME device

 Qubinode recommends using a NVME device for
 storing the VMs disk. The device will be paritioned and
 a LVM volume created and mounted to /var/lib/libvirt/images.

 No additional storage device found.

 You can skip this and use the default
 disk where /var/lib/libvirt/images is mounted.

Do you want to skip configuring additional storage? yes/no yes

 Setting create_lvm to no.

 Enter a upstream DNS server or press [ENTER] for the default [1.1.1.1]: 
Decryption successful
Encryption successful
Decryption successful
 Credentials for RHSM is already collected.

Encryption successful

```I think this step is redundant```

    Red Hat Identity Management (IdM)
    *********************************

 The Qubinode depends on IdM as the DNS server.
 To provide DNS resolutions for the services deployed.
 The installer default action is deploy a local IdM server.
 You can also choose to use an existing IdM server.

 Would you like to use an existing IdM server? yes/no no
 The IdM server will be assigned a dynamic ip address from
 your network. You can assign a static ip address instead.

 Would you like to assign a static ip address to the IdM server? yes/no yes

 Enter the ip address you would like to assign to the IdM server: 192.168.x.x
 You entered 192.168.4.81, is this correct? yes/no yes 
 The qubinode-installer will connect to the IdM server on 192.168.x.x


    ***************************
    *   Setup is complete   *
    ***************************



********************************************
* Ensure host system is registered to RHSM *
*********************************************

Decryption successful
Encryption successful
 kubenode.lab.example is already registered


    *********************************
    *   RHSM registration complete  *
    *********************************



*******************************************************
* Ensure host system is setup as a ansible controller *
*******************************************************



*********************************************
* Ensure host system is setup as a KVM host *
*********************************************
Running ping_nodes



Setting RHEL to the supported release: 7.7Release preference has been unset
Release set to: 7.7
 Setting up qubinode system

Additional context
Add any other context about the problem here.