flyingpie/windows-terminal-quake

float values no longer accepted for *ScreenCoverage

Closed this issue · 3 comments

tdy commented

The *ScreenCoverage settings and terminal bounds are now int:

windows-terminal-quake/windows-terminal-quake/Settings/SettingsDto.cs

Line 47 in d6420c3

public int HorizontalScreenCoverage { get; set; } = 100;

windows-terminal-quake/windows-terminal-quake/Settings/SettingsDto.cs

Line 152 in d6420c3

public int VerticalScreenCoverage { get; set; } = 100;

windows-terminal-quake/windows-terminal-quake/TerminalBoundsProviders/MovingTerminalBoundsProvider.cs

Lines 16 to 17 in d6420c3

var termWidth = (int)(screenBounds.Width * settings.HorizontalScreenCoverageIndex);
var termHeight = (int)(screenBounds.Height * settings.VerticalScreenCoverageIndex);

Previously I was using a float (100.75) to make it flush as described in #12 (comment) and the settings comments:

windows-terminal-quake/windows-terminal-quake/windows-terminal-quake.json

Lines 65 to 68 in d6420c3

// How much horizontal space the terminal should use. When this is below 100, the terminal is centered.
// This can also be above 100, which can be useful to compensate for the window not always taking a 100% of the screen width,
// due to the terminal being bound to column widths (eg. try 100.5 or 101).
"HorizontalScreenCoverage": 80,

Was this a regression or intentional? I'm not able to make the quake window flush with only int settings.

Version: windows-terminal-quake-1.2.0-2021-05-16_1602 binary release

Note that I think this change was intended only for 1.3.0+ (it doesn't exist in 1.2.0's source tree and source zip), but the change is already in effect in the 1.2.0 binary.

flyingpie commented

@tdy Good catch! Will fix this in the next release.

  • 👍1
tdy commented

@flyingpie 1.3.0-2021-07-05_1426 works on my end, thanks!

  • ❤️1