Example implementation blurry on High DPI displays

Question

Example implementation blurry on High DPI displays

Closed this issue 7 years ago · 5 comments

DoctorGester commented 7 years ago

https://www.khronos.org/webgl/wiki/HandlingHighDPI

flyover commented 7 years ago

50df0be

flyover commented 7 years ago

6fba142

Answer 1 · 2018-03-28T01:48:25.000Z

@flyover it's not blurry anymore, but it's small :D
I'm unable to test right now but I think https://github.com/flyover/imgui-js/blob/master/example/imgui_impl.ts#L264-L265 those should use .scrollWidth and .scrollHeight because those supposed to be actual display size (both gl.drawingBufferWidth and gl.canvas.width represent the same thing - internal framebuffer size)

Answer 2 · 2018-03-28T14:23:11.000Z

aff0e3b

I also had to add a viewport meta tag to get it to scale correctly.

Answer 3 · 2018-03-29T23:38:50.000Z

Nice! You would need to rollback your older code which modifies mouse position though because right now it's incorrect.

I'm working on a webassembly version of imgui right now and couldn't figure out a bug with the glViewport call on retina displays (turns out that call wasn't needed), so now I've figured out thanks to your code!