fmaida/hello-dolly-mkdocs-plugin

Fix event prameters

Closed this issue ยท 3 comments

Hello!

First of all, I would like to thanks you for helping beginners like me to create their first mkdocs plugins. That amazing ๐Ÿ˜„

When I first tried to create my own plugin with the help of yours, I got into a problem with the arguments passed to my method on_page_markdown,
I'm not sure if it's an issue with an mkdocs update or because I don't really know python, but I needed to change this line
def on_page_markdown(self, markdown, page, config, site_navigation):
by
def on_page_markdown(self, markdown, page, config, site_navigation=None, **kwargs):
in order to make it work.

Hello and sorry for the delay with which I answer.
I haven't touched my plugin code in a while, it's surely possible that the on_page_markdown is now requiring some further arguments. I'll try to test it in these days and I'll fix the code accordingly.

Thanks for your reporting :-)

Alright, I have fixed the number of arguments passed to the event on_page_markdown. I hope it will work on your develop machine as well as it is working on mine with mkdocs 1.0.4 installed on.

Thanks, I'll test it as soon as I can :)