fnproject/fn

Duplicate agent_submit spans in agent and lb_agent

bharadwr opened this issue · 3 comments

There's two spans with the same name, namely in agent.go and lb_agent.go.

ctx, span := trace.StartSpan(ctx, "agent_submit")

ctx, span := trace.StartSpan(call.req.Context(), "agent_submit")

Should this be renamed? Someone might find a span on jaeger and go down the wrong rabbit hole if theyre debugging (I certainly did)

yes, please - lb_agent likely has a few duplicates from agent, lb_agent_submit is probably sufficient?

Yep, I'll make that change. Lemme see if there's a few more duplicate traces, and I'll add them all to one ticket.

Screen Shot 2019-06-27 at 11 00 22 AM
It's gonna look like this, added some more span attributes that are probably useful
Couldn't find any duplicate spans besides this